Researchers at Truffle Security have found, or arguably rediscovered, that data from deleted GitHub repositories (public or private) and from deleted copies (forks) of repositories isn’t necessarily deleted.
Joe Leon, a security researcher with the outfit, said in an advisory on Wednesday that being able to access deleted repo data – such as APIs keys – represents a security risk. And he proposed a new term to describe the alleged vulnerability: Cross Fork Object Reference (CFOR).
“A CFOR vulnerability occurs when one repository fork can access sensitive data from another fork (including data from private and deleted forks),” Leon explained.
For example, the firm showed how one can fork a repository, commit data to it, delete the fork, and then access the supposedly deleted commit data via the original repository.
The researchers also created a repo, forked it, and showed how data not synced with the fork continues to be accessible through the fork after the original repo is deleted. You can watch that particular demo.
Oh god. That means all the spaghetti code that I ever wrote is still out there.
Yup. Along with the code from huge organizations. I always thought it was funny that people put their code online, blindly trusting some random company that got gobbled up by Microsoft.
Along with every private key that was accidentally committed.
Ha ha, way way back in the day when I didn’t understand how keys worked, I sent a private key to another developer when they asked for my public. They were kind enough to educate me.
As a lifelong troll, I would’ve just generated a new pub key and made a bunch of commits as you. Then two days later, I would tell you what’s up once you had time to process the confusion.
Your point is valid, but many (most?) enterprises don’t use a forking worlflow, so I suspect open source projects will be hit harder, sadly
Not only just out there. I am regenerating your spaghetti code into a new context with copilot 🧑✈️ Your (ai-regenerated) code will be driving our military nuclear launch code base! Congratulations!
Your (ai-regenerated) code will be driving our military nuclear launch code base!
What’s so difficult about writing code that checks if you have 8 zeroes?
https://gizmodo.com/for-20-years-the-nuclear-launch-code-at-us-minuteman-si-1473483587
Oh I’m just the cleaning guy, so I don’t really know how to code it myself. We laid off all the developers three weeks ago.
My people!
This is not a GitHub issue. It’s a GIT feature. People are always going to clone your repo.
Well, sort of. GitHub certainly could refuse to render orphan commits. They pop up a banner saying so but I don’t see why they should show the commit at all. They could still keep the data until it’s garbage collected since a user might re-upload the commit in a new branch.
This seems like a non-issue though since someone who hasn’t already seen the disclosed information would need to somehow determine the hash of the deleted commit.
Ah - Actually reading the article reveals why this is actually an issue:
What’s more, Ayrey explained, you don’t even need the full identifying hash to access the commit. “If you know the first four characters of the identifier, GitHub will almost auto-complete the rest of the identifier for you,” he said, noting that with just sixty-five thousand possible combinations for those characters, that’s a small enough number to test all the possibilities.
So enumerating all the orphan commits wouldn’t be that hard.
In any case if a secret has been publicly disclosed, you should always assume it’s still out there. For sure, rotate your keys.
Forks do not exist in git. It’s a GitHub feature, and a massive blunder at the same time.
Yes they exist. It’s called a clone
The article is specifically about how GitHub forks are not the same as a git clone. A clone isn’t accessible from the upstream without the upstream pulling the changes, but this vulnerability points out that a fork on GitHub is accessible from the upstream without a pull, even if the fork is private.
It’s because GitHub under the hood doesn’t actually do a real clone so that they can save on disk usage.
You actually can’t turn a fork private on github
How can such a wrong answer get so many points? Clones and forge forks are unrelated. First, GitHub or GitLab cannot and could not link clones together without analyzing the remotes of each clone.
FFS it’s a tech community…
Because you are the one being wrong. Github and others only provide a nice interface around clones. That’s all there is, and it doesn’t matter much
So many OpenAI keys!
Classic microsoft. Use other git instances please. If you want actions you can use any public Forejo instance.
that’s a direct cause of how forks work, it most likely predates microsoft’s acquisition
You mean Forgejo?
Yes, forgejo. My hands are cold :s
Fun fact, it comes from the Esperanto: forĝejo. Try typing that with cold fingers. :)
Imagine creating a whole new “universal” language and using such shitty diacritics that nobody likes
Yeah, kinda dumb. But they do have a relatively popular workaround: the x-system. So forĝejo becomes forgxejo (x = diacritic for the prev letter).
Like lojban!
